Hi Voon,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on net-next/master]

url:    
https://github.com/0day-ci/linux/commits/Voon-Weifeng/net-stmmac-Enable-EEE-HW-LPI-timer-with-auto-SW-HW-switching/20201016-000231
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 
d25e2e9388eda61b6e298585024ee3355f50c493
config: x86_64-randconfig-a012-20201015 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 
e7b4feea8e1bf520b34ad8c116abab6677344b74)
reproduce (this is a W=1 build):
        wget 
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O 
~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install x86_64 cross compiling tool for clang build
        # apt-get install binutils-x86-64-linux-gnu
        # 
https://github.com/0day-ci/linux/commit/b208a1e7f74a391d1d7c2950e35b97c59af55585
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review 
Voon-Weifeng/net-stmmac-Enable-EEE-HW-LPI-timer-with-auto-SW-HW-switching/20201016-000231
        git checkout b208a1e7f74a391d1d7c2950e35b97c59af55585
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <l...@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:297:6: warning: no 
>> previous prototype for function 'stmmac_lpi_entry_timer_config' 
>> [-Wmissing-prototypes]
   void stmmac_lpi_entry_timer_config(struct stmmac_priv *priv, bool en)
        ^
   drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:297:1: note: declare 
'static' if the function is not intended to be used outside of this translation 
unit
   void stmmac_lpi_entry_timer_config(struct stmmac_priv *priv, bool en)
   ^
   static 
   1 warning generated.

vim +/stmmac_lpi_entry_timer_config +297 
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c

   296  
 > 297  void stmmac_lpi_entry_timer_config(struct stmmac_priv *priv, bool en)
   298  {
   299          int tx_lpi_timer;
   300  
   301          /* Clear/set the SW EEE timer flag based on LPI ET enablement */
   302          priv->eee_sw_timer_en = en ? 0 : 1;
   303          tx_lpi_timer  = en ? priv->tx_lpi_timer : 0;
   304          stmmac_set_eee_lpi_timer(priv, priv->hw, tx_lpi_timer);
   305  }
   306  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org

Attachment: .config.gz
Description: application/gzip

Reply via email to