Hi, On Fri, Oct 16, 2020 at 12:27 PM Evan Green <[email protected]> wrote: > > Add SoC-specific compatible strings so that data can be attached > to it in the driver. > > Signed-off-by: Evan Green <[email protected]> > --- > > Changes in v2: > - Add other soc compatible strings (Doug) > - Fix compatible string definition (Doug) > > .../devicetree/bindings/nvmem/qcom,qfprom.yaml | 13 ++++++++++++- > 1 file changed, 12 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/nvmem/qcom,qfprom.yaml > b/Documentation/devicetree/bindings/nvmem/qcom,qfprom.yaml > index 1a18b6bab35e7..eb1440045aff1 100644 > --- a/Documentation/devicetree/bindings/nvmem/qcom,qfprom.yaml > +++ b/Documentation/devicetree/bindings/nvmem/qcom,qfprom.yaml > @@ -14,7 +14,18 @@ allOf: > > properties: > compatible: > - const: qcom,qfprom > + items: > + - enum: > + - qcom,apq8064-qfprom > + - qcom,apq8084-qfprom > + - qcom,msm8974-qfprom > + - qcom,msm8916-qfprom > + - qcom,msm8996-qfprom > + - qcom,msm8998-qfprom > + - qcom,qcs404-qfprom > + - qcom,sc7180-qfprom > + - qcom,sdm845-qfprom > + - const: qcom,qfprom > > reg: > # If the QFPROM is read-only OS image then only the corrected region
As Rob's bot found, your example no longer matches your requirements. It needs an SoC-specific string plus the "qcom,qfprom". It's always good to try running "make dt_binding_check" to catch these sorts of things. -Doug
