.On Wed, Oct 21, 2020 at 7:36 PM Joe Perches <[email protected]> wrote: > > Use a more generic form for __section that requires quotes to avoid > complications with clang and gcc differences. > > Remove the quote operator # from compiler_attributes.h __section macro. > > Convert all unquoted __section(foo) uses to quoted __section("foo"). > Also convert __attribute__((section("foo"))) uses to __section("foo") > even if the __attribute__ has multiple list entry forms. > > Conversion done using a script: > > Link: > https://lore.kernel.org/lkml/[email protected]/2-convert_section.pl > > Signed-off-by: Joe Perches <[email protected]> > --- > > This conversion was previously submitted to -next last month > https://lore.kernel.org/lkml/[email protected]/ > > Nick Desaulniers found a defect in the conversion of 2 boot files > for powerpc, but no other defect was found for any other arch.
Untested, but: Reviewed-by: Nick Desaulniers <[email protected]> Good job handling the trickier cases when the attribute was mixed with others, and printing it in scripts/mod/modpost.c. The only cases that *might* be similar to PPC are: > arch/s390/boot/startup.c | 2 +- > arch/x86/boot/compressed/pgtable_64.c | 2 +- > arch/x86/purgatory/purgatory.c | 4 ++-- So a quick test of x86_64 and s390 would be good. Thanks for the patch. > > The script was corrected to avoid converting these 2 files. > > There is no difference between the script output when run on today's -next > and Linus' tree through commit f804b3159482, so this should be reasonable to > apply now. -- Thanks, ~Nick Desaulniers
