On Mon, Oct 26, 2020 at 03:03:13PM +0100, Sebastian Andrzej Siewior wrote:
> From: "Ahmed S. Darwish" <[email protected]>
>
> The usage of in_interrupt() in drivers is phased out and Linus clearly
> requested that code which changes behaviour depending on context should
> either be separated or the context be conveyed in an argument passed by the
> caller, which usually knows the context.
>
> The debug printk() in digi_write() prints in_interrupt() as context
> information. This information is imprecisely as it does not distinguish
> between hard-IRQ or disabled botton half and it does consider disabled
> interrupts or preemption. It is not really helpful.
I fixed up a couple of typos and added the missing negation above so
that it reads:
The debug printk() in digi_write() prints in_interrupt() as context
information. This information is imprecise as it does not distinguish
between hard-IRQ or disabled bottom half and it does not consider
disabled interrupts or preemption. It is not really helpful.
> Remove the in_interrupt() printout.
>
> Signed-off-by: Ahmed S. Darwish <[email protected]>
> Signed-off-by: Thomas Gleixner <[email protected]>
> Signed-off-by: Sebastian Andrzej Siewior <[email protected]>
> Cc: Johan Hovold <[email protected]>
> Cc: Greg Kroah-Hartman <[email protected]>
> Cc: [email protected]
> ---
> v2…v3:
> - Don't make dev_dbg() conditional on `tty'
> - Remove the part "tty happens always in process context" from the
> commit message. Johan pointed out that for PPP it may happen in
> bottom half.
Now applied for -next, thanks.
Johan
