On Mon, Oct 26, 2020 at 05:14:39PM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann <[email protected]> > > There are hundreds of warnings in a W=2 build about a local > variable shadowing the global 'apic' definition: > > arch/x86/kvm/lapic.h:149:65: warning: declaration of 'apic' shadows a global > declaration [-Wshadow] > > Avoid this by renaming the local in the kvm/lapic.h header
Rather than change KVM, and presumably other files as well, e.g. kvm/lapic.c and apic/io_apic.c also shadow 'apic' all over the place, what about renaming the global 'apic' to something more unique? KVM aside, using such a common name for a global variable has always struck me as a bit odd/dangerous/confusing.
