The following commit has been merged into the x86/apic branch of tip:

Commit-ID:     93b7a3d6a1f0f159d390959de7a1b9ad863d6b26
Gitweb:        
https://git.kernel.org/tip/93b7a3d6a1f0f159d390959de7a1b9ad863d6b26
Author:        Thomas Gleixner <[email protected]>
AuthorDate:    Sat, 24 Oct 2020 22:35:03 +01:00
Committer:     Thomas Gleixner <[email protected]>
CommitterDate: Wed, 28 Oct 2020 20:26:24 +01:00

x86/apic/uv: Fix inconsistent destination mode

The UV x2apic is strictly using physical destination mode, but
apic::dest_logical is initialized with APIC_DEST_LOGICAL.

This does not matter much because UV does not use any of the generic
functions which use apic::dest_logical, but is still inconsistent.

Signed-off-by: Thomas Gleixner <[email protected]>
Signed-off-by: David Woodhouse <[email protected]>
Signed-off-by: Thomas Gleixner <[email protected]>
Link: https://lore.kernel.org/r/[email protected]

---
 arch/x86/kernel/apic/x2apic_uv_x.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/kernel/apic/x2apic_uv_x.c 
b/arch/x86/kernel/apic/x2apic_uv_x.c
index 714233c..9ade9e6 100644
--- a/arch/x86/kernel/apic/x2apic_uv_x.c
+++ b/arch/x86/kernel/apic/x2apic_uv_x.c
@@ -811,7 +811,7 @@ static struct apic apic_x2apic_uv_x __ro_after_init = {
        .irq_dest_mode                  = 0, /* Physical */
 
        .disable_esr                    = 0,
-       .dest_logical                   = APIC_DEST_LOGICAL,
+       .dest_logical                   = APIC_DEST_PHYSICAL,
        .check_apicid_used              = NULL,
 
        .init_apic_ldr                  = uv_init_apic_ldr,

Reply via email to