Hi, I love your patch! Perhaps something to improve:
[auto build test WARNING on hwmon/hwmon-next] [also build test WARNING on linus/master linux/master v5.10-rc1 next-20201029] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/alexandru-tachici-analog-com/hwmon-ltc2992-Add-support/20201029-174720 base: https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git hwmon-next config: x86_64-randconfig-r023-20201030 (attached as .config) compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 772aaa602383cf82795572ebcd86b0e660f3579f) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install x86_64 cross compiling tool for clang build # apt-get install binutils-x86-64-linux-gnu # https://github.com/0day-ci/linux/commit/f74af3cc59b7d9de6545502e7d01df6e01f96773 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review alexandru-tachici-analog-com/hwmon-ltc2992-Add-support/20201029-174720 git checkout f74af3cc59b7d9de6545502e7d01df6e01f96773 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <[email protected]> All warnings (new ones prefixed by >>): >> drivers/hwmon/ltc2992.c:276:6: warning: no previous prototype for function >> 'ltc2992_gpio_set_multiple' [-Wmissing-prototypes] void ltc2992_gpio_set_multiple(struct gpio_chip *chip, unsigned long *mask, unsigned long *bits) ^ drivers/hwmon/ltc2992.c:276:1: note: declare 'static' if the function is not intended to be used outside of this translation unit void ltc2992_gpio_set_multiple(struct gpio_chip *chip, unsigned long *mask, unsigned long *bits) ^ static 1 warning generated. vim +/ltc2992_gpio_set_multiple +276 drivers/hwmon/ltc2992.c 275 > 276 void ltc2992_gpio_set_multiple(struct gpio_chip *chip, unsigned long > *mask, unsigned long *bits) 277 { 278 struct ltc2992_state *st = gpiochip_get_data(chip); 279 unsigned long gpio_ctrl_io = 0; 280 unsigned long gpio_ctrl = 0; 281 unsigned int gpio_nr; 282 283 for_each_set_bit(gpio_nr, mask, LTC2992_GPIO_NR) { 284 if (gpio_nr < 3) 285 assign_bit(ltc2992_gpio_addr_map[gpio_nr].ctrl_bit, &gpio_ctrl_io, true); 286 287 if (gpio_nr == 3) 288 assign_bit(ltc2992_gpio_addr_map[gpio_nr].ctrl_bit, &gpio_ctrl, true); 289 } 290 291 mutex_lock(&st->gpio_mutex); 292 ltc2992_write_reg(st, LTC2992_GPIO_IO_CTRL, 1, gpio_ctrl_io); 293 ltc2992_write_reg(st, LTC2992_GPIO_CTRL, 1, gpio_ctrl); 294 mutex_unlock(&st->gpio_mutex); 295 } 296 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/[email protected]
.config.gz
Description: application/gzip
