Hi Shawn, I will document "nxp,lx2162a-qds". For ethernet string, documentation seems correct.
Thanks, Meenakshi > -----Original Message----- > From: Leo Li <[email protected]> > Sent: Monday, October 26, 2020 8:06 PM > To: Shawn Guo <[email protected]>; Meenakshi Aggarwal > <[email protected]> > Cc: [email protected]; Varun Sethi <[email protected]>; linux-arm- > [email protected]; [email protected]; linux- > [email protected]; Ioana Ciornei <[email protected]>; Kuldeep Singh > <[email protected]> > Subject: RE: [PATCH v3 2/2] arm64: dts: lx2160a: add device tree for > lx2162aqds > board > > > > > -----Original Message----- > > From: Shawn Guo <[email protected]> > > Sent: Monday, October 26, 2020 2:19 AM > > To: Meenakshi Aggarwal <[email protected]> > > Cc: [email protected]; Varun Sethi <[email protected]>; Leo Li > > <[email protected]>; [email protected]; > > [email protected]; [email protected]; Ioana > > Ciornei <[email protected]>; Kuldeep Singh <[email protected]> > > Subject: Re: [PATCH v3 2/2] arm64: dts: lx2160a: add device tree for > > lx2162aqds board > > > > On Mon, Oct 19, 2020 at 09:00:33AM +0000, Meenakshi Aggarwal wrote: > > > Hi, > > > > > > Any further comments? > > > > Please address the following checkpatch warnings. > > > > WARNING: DT compatible string "nxp,lx2162a-qds" appears un-documented > > -- check ./Documentation/devicetree/bindings/ > > #49: FILE: arch/arm64/boot/dts/freescale/fsl-lx2162a-qds.dts:13: > > + compatible = "nxp,lx2162a-qds", "fsl,lx2160a"; > > > > WARNING: DT compatible string "ethernet-phy-id001c.c916" appears un- > > documented -- check ./Documentation/devicetree/bindings/ > > #80: FILE: arch/arm64/boot/dts/freescale/fsl-lx2162a-qds.dts:44: > > + compatible = "ethernet-phy-id001c.c916"; > > Interesting that it doesn't match the following in > Documentation/devicetree/bindings/net/ethernet-phy.yaml > > - pattern: "^ethernet-phy-id[a-f0-9]{4}\\.[a-f0-9]{4}$" > description: > If the PHY reports an incorrect ID (or none at all) then the > compatible list may contain an entry with the correct PHY ID > in the above form. > The first group of digits is the 16 bit Phy Identifier 1 > register, this is the chip vendor OUI bits 3:18. The > second group of digits is the Phy Identifier 2 register, > this is the chip vendor OUI bits 19:24, followed by 10 > bits of a vendor specific ID. > > > > > WARNING: DT compatible string "ethernet-phy-id001c.c916" appears un- > > documented -- check ./Documentation/devicetree/bindings/ > > #92: FILE: arch/arm64/boot/dts/freescale/fsl-lx2162a-qds.dts:56: > > + compatible = "ethernet-phy-id001c.c916"; > > > > > > Shawn
