On Wed, Oct 28, 2020 at 10:14:52AM +0000, Yeh, Andy wrote: > >-----Original Message----- > >From: Sakari Ailus <[email protected]> > >Sent: Wednesday, October 28, 2020 6:03 PM > >To: Krzysztof Kozlowski <[email protected]> > >Cc: Yeh, Andy <[email protected]>; Mauro Carvalho Chehab > ><[email protected]>; Tomasz Figa <[email protected]>; Jason Chen > ><[email protected]>; Alan Chiang <[email protected]>; linux- > >[email protected]; [email protected]; > >[email protected] > >Subject: Re: [PATCH] media: i2c: imx258: correct mode to GBGB/RGRG > > > >On Wed, Oct 28, 2020 at 10:56:55AM +0100, Krzysztof Kozlowski wrote: > >> On Wed, 28 Oct 2020 at 10:45, Krzysztof Kozlowski <[email protected]> > >wrote: > >> > > >> > On Wed, 28 Oct 2020 at 10:43, Yeh, Andy <[email protected]> wrote: > >> > > > >> > > But the sensor settings for the original submission is to output GRBG > >Bayer RAW. > >> > > > >> > > Regards, Andy > >> > > >> > No, not to my knowledge. There are no settings for color output > >> > because it is fixed to GBGB/RGRG. I was looking a lot into this > >> > driver (I have few other problems with it, already few other patches > >> > posted) and I could not find a setting for this in datasheet. If you > >> > know the setting for the other color - can you point me to it? > >> > >> And except the datasheet which mentions the specific format, the > >> testing confirms it. With original color the pictures are pink/purple. > >> With proper color, the pictures are correct (with more green color as > >> expected for bayer). > > > >Quoting the driver's start_streaming function: > > > > /* Set Orientation be 180 degree */ > > ret = imx258_write_reg(imx258, REG_MIRROR_FLIP_CONTROL, > > IMX258_REG_VALUE_08BIT, > > REG_CONFIG_MIRROR_FLIP); > > if (ret) { > > dev_err(&client->dev, "%s failed to set orientation\n", > > __func__); > > return ret; > > } > > > >Could it be you're taking pictures of pink objects? ;-) > > > >-- > >Sakari Ailus > > Sakari is right. IIRC since the default sensor settings outputs in GBRG, and > after mirro/flip (it is the original application when submit the driver) the > bayer order will be GRBG.
Yes, you are all right. It seems I was using wrong color mode for Gstreamer, or I messed up something more. Thanks for help everyone! The patch can be dropped. Best regards, Krzysztof
