On Tue, Nov 03, 2020 at 06:29:01PM +0100, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski <[email protected]> > > The way the driver is implemented is buggy for the (admittedly unlikely) > use case where there are two RTCs with one having an interrupt configured > and the second not. This is caused by the fact that we use a global > rtc_class_ops struct which we modify depending on whether the irq number > is present or not. > > Fix it by using two const ops structs with and without alarm operations. > While at it: not being able to request a configured interrupt is an error > so don't ignore it and bail out of probe(). > > Fixes: ed13d89b08e3 ("rtc: Add Epson RX8010SJ RTC driver") > Signed-off-by: Bartosz Golaszewski <[email protected]> > Signed-off-by: Alexandre Belloni <[email protected]> > Cc: [email protected] > Link: https://lore.kernel.org/r/[email protected] > --- > drivers/rtc/rtc-rx8010.c | 24 +++++++++++++++++------- > 1 file changed, 17 insertions(+), 7 deletions(-)
Now queued up, thanks! greg k-h
