On Thu, 2020-11-05 at 08:23 +0000, Lee Jones wrote:
> On Wed, 04 Nov 2020, Lee Jones wrote:
>
> > On Wed, 28 Oct 2020, Matti Vaittinen wrote:
> >
> > > Add core support for ROHM BD9576MUF and BD9573MUF PMICs which are
> > > mainly used to power the R-Car series processors.
> > >
> > > Signed-off-by: Matti Vaittinen <matti.vaitti...@fi.rohmeurope.com
> > > >
> > > ---
> > > drivers/mfd/Kconfig | 11 +++
> > > drivers/mfd/Makefile | 1 +
> > > drivers/mfd/rohm-bd9576.c | 130
> > > +++++++++++++++++++++++++++++++
> > > include/linux/mfd/rohm-bd957x.h | 59 ++++++++++++++
> > > include/linux/mfd/rohm-generic.h | 2 +
> > > 5 files changed, 203 insertions(+)
> > > create mode 100644 drivers/mfd/rohm-bd9576.c
> > > create mode 100644 include/linux/mfd/rohm-bd957x.h
>
> [...]
>
> > > +static const struct regmap_range volatile_ranges[] = {
> > > + {
> > > + .range_min = BD957X_REG_SMRB_ASSERT,
> > > + .range_max = BD957X_REG_SMRB_ASSERT,
> > > + },
> > > + {
> >
> > The way you space your braces is not consistent.
> >
> > > + .range_min = BD957X_REG_PMIC_INTERNAL_STAT,
> > > + .range_max = BD957X_REG_PMIC_INTERNAL_STAT,
> > > + },
> > > + {
> > > + .range_min = BD957X_REG_INT_THERM_STAT,
> > > + .range_max = BD957X_REG_INT_THERM_STAT,
> > > + },
> > > + {
> > > + .range_min = BD957X_REG_INT_OVP_STAT,
> > > + .range_max = BD957X_REG_INT_SYS_STAT,
> > > + }, {
> > > + .range_min = BD957X_REG_INT_MAIN_STAT,
> > > + .range_max = BD957X_REG_INT_MAIN_STAT,
> > > + },
> > > +};
>
> Don't forget about this.
>
> I would prefer to have the braces on the same line (even if it means
> you have to change an extra line when editing), but I'm not 100% dead
> set on it. Consistency however, I am.
>
I won't forget. I intended to write that I was Ok with all the other
comments. Maybe I forgot though. Anyways, I'll fix the inconsistency -
thanks for pointing it out!
--Matti
