On 05-11-20, 12:55, Ionela Voinescu wrote: > For errors parsing the _PSD domains, a separate domain is returned for > each CPU in the failed _PSD domain with no coordination (as per previous > comment). But contrary to the intention, the code was setting > CPUFREQ_SHARED_TYPE_ALL as coordination type. > > Change shared_type to CPUFREQ_SHARED_TYPE_NONE in case of errors parsing > the domain information. The function still return the error and the caller > is free to bail out the domain initialisation altogether in that case. > > Given that both functions return domains with a single CPU, this change > does not affect the functionality, but clarifies the intention. > > Signed-off-by: Ionela Voinescu <[email protected]> > Cc: Rafael J. Wysocki <[email protected]> > Cc: Len Brown <[email protected]> > Cc: Viresh Kumar <[email protected]> > --- > drivers/acpi/cppc_acpi.c | 2 +- > drivers/acpi/processor_perflib.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/acpi/cppc_acpi.c b/drivers/acpi/cppc_acpi.c > index 75e36b909ae6..e1e46cc66eeb 100644 > --- a/drivers/acpi/cppc_acpi.c > +++ b/drivers/acpi/cppc_acpi.c > @@ -477,7 +477,7 @@ int acpi_get_psd_map(unsigned int cpu, struct psd_data > *domain) > /* Assume no coordination on any error parsing domain info */ > cpumask_clear(domain->shared_cpu_map); > cpumask_set_cpu(cpu, domain->shared_cpu_map); > - domain->shared_type = CPUFREQ_SHARED_TYPE_ALL; > + domain->shared_type = CPUFREQ_SHARED_TYPE_NONE; > > return -EFAULT; > } > diff --git a/drivers/acpi/processor_perflib.c > b/drivers/acpi/processor_perflib.c > index 5909e8fa4013..5ce638537791 100644 > --- a/drivers/acpi/processor_perflib.c > +++ b/drivers/acpi/processor_perflib.c > @@ -710,7 +710,7 @@ int acpi_processor_preregister_performance( > if (retval) { > cpumask_clear(pr->performance->shared_cpu_map); > cpumask_set_cpu(i, pr->performance->shared_cpu_map); > - pr->performance->shared_type = CPUFREQ_SHARED_TYPE_ALL; > + pr->performance->shared_type = CPUFREQ_SHARED_TYPE_NONE; > } > pr->performance = NULL; /* Will be set for real in register */ > }
Acked-by: Viresh Kumar <[email protected]> -- viresh
