Re: [PATCH v1 2/3] vt: keyboard, replace numbers with \r, \n where appropriate

[Jiri Slaby]

On 06. 11. 20, 15:35, Andy Shevchenko wrote:

Instead of 10, 13 use \n, \r respectively.

Signed-off-by: Andy Shevchenko <andriy.shevche...@linux.intel.com>

Acked-by: Jiri Slaby <jirisl...@kernel.org>

---
  drivers/tty/vt/keyboard.c | 6 +++---
  1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/tty/vt/keyboard.c b/drivers/tty/vt/keyboard.c
index bfe54b9822af..647c343f61fb 100644
--- a/drivers/tty/vt/keyboard.c
+++ b/drivers/tty/vt/keyboard.c
@@ -462,9 +462,9 @@ static void fn_enter(struct vc_data *vc)
                diacr = 0;
        }

- put_queue(vc, 13);

+       put_queue(vc, '\r');
        if (vc_kbd_mode(kbd, VC_CRLF))
-               put_queue(vc, 10);
+               put_queue(vc, '\n');
  }

static void fn_caps_toggle(struct vc_data *vc)

@@ -827,7 +827,7 @@ static void k_pad(struct vc_data *vc, unsigned char value, 
char up_flag)

put_queue(vc, pad_chars[value]);

        if (value == KVAL(K_PENTER) && vc_kbd_mode(kbd, VC_CRLF))
-               put_queue(vc, 10);
+               put_queue(vc, '\n');
  }

static void k_shift(struct vc_data *vc, unsigned char value, char up_flag)

--
js
suse labs