On 10. 11. 20 11:04, Michal Simek wrote:
>
>
> On 10. 11. 20 2:15, Yu Kuai wrote:
>> If clk_notifier_register() failed, ttc_setup_clockevent() will return
>> without freeing 'ttcce', which will leak memory.
>>
>> Fixes: 70504f311d4b ("clocksource/drivers/cadence_ttc: Convert init function
>> to return error")
>> Reported-by: Hulk Robot <[email protected]>
>> Signed-off-by: Yu Kuai <[email protected]>
>> ---
>> drivers/clocksource/timer-cadence-ttc.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/clocksource/timer-cadence-ttc.c
>> b/drivers/clocksource/timer-cadence-ttc.c
>> index 80e960602030..32b9560ce408 100644
>> --- a/drivers/clocksource/timer-cadence-ttc.c
>> +++ b/drivers/clocksource/timer-cadence-ttc.c
>> @@ -426,6 +426,7 @@ static int __init ttc_setup_clockevent(struct clk *clk,
>> &ttcce->ttc.clk_rate_change_nb);
>> if (err) {
>> pr_warn("Unable to register clock notifier.\n");
>> + kfree(ttcce);
>> return err;
>> }
>>
>>
>
> Reviewed-by: Michal Simek <[email protected]>
One thing I have noticed. Please fix your subject. Remove " from it.
Thanks,
Michal
