On 11/13/20 10:59 AM, Sami Tolvanen wrote: > On Fri, Nov 13, 2020 at 10:35 AM Randy Dunlap <rdun...@infradead.org> wrote: >> >> On 11/13/20 10:26 AM, Sami Tolvanen wrote: >>> e820__mapped_all is passed as a callback to is_mmconf_reserved, which >>> expects a function of type: >>> >>> typedef bool (*check_reserved_t)(u64 start, u64 end, unsigned type); >>> >>> This trips indirect call checking with Clang's Control-Flow Integrity >>> (CFI). Change the last argument from enum e820_type to unsigned to fix >>> the type mismatch. >> >> Hi, >> >> Kernel style is no raw unsigned -- use unsigned int or unsigned long, please. >> >> checkpatch should or could have found that issue. > > It did, but the existing type definition for the callback in > pci/mmconfig-shared.c uses raw unsigned. I can add a patch to change > that to unsigned int as well, if you prefer.
Hm. :) Well, yes, I prefer, but I can't require it. thanks for the explanation. -- ~Randy
