On 13-11-20, 16:34, xiakaixu1...@gmail.com wrote:
> From: Kaixu Xia <kaixu...@tencent.com>
>
> The value of variable error is overwritten by the following call
> devm_request_threaded_irq() in phy_mdm6600_device_power_on(), so here the
> value assignment is useless. Remove it.
>
> Reported-by: Tosk Robot <tencent_os_ro...@tencent.com>
> Signed-off-by: Kaixu Xia <kaixu...@tencent.com>
> ---
> drivers/phy/motorola/phy-mapphone-mdm6600.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/phy/motorola/phy-mapphone-mdm6600.c
> b/drivers/phy/motorola/phy-mapphone-mdm6600.c
> index 5172971..24ab848 100644
> --- a/drivers/phy/motorola/phy-mapphone-mdm6600.c
> +++ b/drivers/phy/motorola/phy-mapphone-mdm6600.c
> @@ -421,7 +421,6 @@ static int phy_mdm6600_device_power_on(struct phy_mdm6600
> *ddata)
> dev_info(ddata->dev, "Powered up OK\n");
> } else {
> ddata->enabled = false;
> - error = -ETIMEDOUT;
> dev_err(ddata->dev, "Timed out powering up\n");
Maybe the right fix is adding return error here..?
--
~Vinod
