+ ath10k list kernel test robot <[email protected]> writes:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > master > head: f01c30de86f1047e9bae1b1b1417b0ce8dcd15b1 > commit: 3c45f21af84eb05a355919abc80cf70a3a681cee ath10k: sdio: add > firmware coredump support > compiler: nios2-linux-gcc (GCC) 9.3.0 > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot <[email protected]> > > > cppcheck possible warnings: (new ones prefixed by >>, may not real problems) > >>> drivers/net/wireless/ath/ath10k/sdio.c:2234:2: warning: Non-boolean > value returned from function returning bool > [returnNonBoolInBooleanFunction] > return param & HI_OPTION_SDIO_CRASH_DUMP_ENHANCEMENT_FW; > ^ Is this really a problem? I guess we could change that to "!!(param & HI_OPTION_SDIO_CRASH_DUMP_ENHANCEMENT_FW)" but how is that better and does it make any practical difference when ath10k_sdio_is_fast_dump_supported() returns a boolean anyway? -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
