On Mon, 2020-11-23 at 23:28 -0800, Can Guo wrote:
> +++ b/drivers/scsi/ufs/ufshcd.h
> @@ -229,6 +229,8 @@ struct ufs_dev_cmd {
> * @max_freq: maximum frequency supported by the clock
> * @min_freq: min frequency that can be used for clock scaling
> * @curr_freq: indicates the current frequency that it is set to
> + * @always_on_while_link_active: indicate that the clk should not be
> disabled if
> + link is still active
> * @enabled: variable to check against multiple enable/disable
> */
> struct ufs_clk_info {
> @@ -238,6 +240,7 @@ struct ufs_clk_info {
> u32 max_freq;
> u32 min_freq;
> u32 curr_freq;
> + bool always_on_while_link_active;
Can,
using a sentence as a parameter name looks a little bit clumsy to me.
The meaning has been explained in the comments section. How about
simplify it and in line with other parameters in the structure?
Thanks,
Bean
> bool enabled;
> };
>
