On Fri, Nov 27, 2020 at 01:53:28PM +0100, Guido Günther wrote: > This is more in line with what tcpm does and will be needed > to avoid recursive dependency like > > > drivers/power/supply/Kconfig:2:error: recursive dependency detected! > drivers/power/supply/Kconfig:2: symbol POWER_SUPPLY is selected by > TYPEC_TPS6598X > drivers/usb/typec/Kconfig:64: symbol TYPEC_TPS6598X depends on REGMAP_I2C > drivers/base/regmap/Kconfig:19: symbol REGMAP_I2C is selected by > CHARGER_ADP5061 > drivers/power/supply/Kconfig:93: symbol CHARGER_ADP5061 depends on > POWER_SUPPLY > For a resolution refer to Documentation/kbuild/kconfig-language.rst > subsection "Kconfig recursive dependency limitations" > > when selecting POWER_SUPPLY. > > Signed-off-by: Guido Günther <[email protected]>
Reviewed-by: Heikki Krogerus <[email protected]> > --- > drivers/usb/typec/Kconfig | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/usb/typec/Kconfig b/drivers/usb/typec/Kconfig > index 6c5908a37ee8..772b07e9f188 100644 > --- a/drivers/usb/typec/Kconfig > +++ b/drivers/usb/typec/Kconfig > @@ -64,8 +64,8 @@ config TYPEC_HD3SS3220 > config TYPEC_TPS6598X > tristate "TI TPS6598x USB Power Delivery controller driver" > depends on I2C > - depends on REGMAP_I2C > - depends on USB_ROLE_SWITCH || !USB_ROLE_SWITCH > + select REGMAP_I2C > + select USB_ROLE_SWITCH > help > Say Y or M here if your system has TI TPS65982 or TPS65983 USB Power > Delivery controller. > -- > 2.29.2 thanks, -- heikki
