On Wed, 2007-12-12 at 15:00 -0800, Jeremy Fitzhardinge wrote: > Harvey Harrison wrote: > > Some kprobe structure members had a superfluous e in their > > name. > > > > eflags -> flags > > esp -> sp > > > > eflags and esp are the actual machine register names (at least in > 32-bit), and therefore more distinctive than just "flags". > > If this is in preparation for a unification then OK, but I disagree if > not (and technically 64-bit should be using rsp/rflags). > > J
My plan was to move forward with unifying these files. If this is still acceptable I will add a comment block documenting this. This doesn't affect anywhere outside of kprobes.h kprobes_32/64.c so if it is clean to unify them, I'll leave them as sp with comment. Harvey -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
