On Thu, Dec 3, 2020 at 2:44 PM Miguel Ojeda <[email protected]> wrote: > > On Thu, Dec 3, 2020 at 8:26 AM Lukas Bulwahn <[email protected]> wrote: > > > > It is not a competition between checkpatch and clang-format, but if it > > would be: > > Please note that clang-tidy is a different tool, it is designed to > write lints based on the AST rather than formatting. > > > But jokes aside: Dwaipayan Ray, a mentee Joe and I are working with, > > has already submitted a patch to checkpatch that identifies those > > patterns and provides a fix: > > > > https://lore.kernel.org/lkml/[email protected]/ > > That is very good! However, it does not hurt to have it repeated in > clang-tidy too: it is a very good thing to have a full C parser behind > when writing lints! >
Completely agree. A regular expression is only a limited (but quite powerful) heuristics to a full C parser :) ... and it did a good job in the case here. Lukas > Cheers, > Miguel
