On 2020-12-04, Sergey Senozhatsky <[email protected]> wrote: >> +static char *get_printk_count(void) > > A nit: I think get_foo() has some sort of special meaning and one > would expect that there should be put_foo() as well, and that those > have something to do with the ref counting.
OK. How about: static char *printk_recursion_counter(void) ? >> +static bool printk_enter(unsigned long *flags) > > This better explicitly state that it disables local IRQs > > printk_enter_irqsave() > > I'm not very certain that printk_enter/printk_exit are best names: > > if (!printk_enter()) > return; > > Maybe it can spell out why we couldn't enter printk so the function > name can contain recursion_limit or something. printk_recurse_irqsave() ? I would prefer printk_enter_irqsave() and just add comments that say it is checking the recursion level. It is only used in one place. >> +static void printk_exit(unsigned long flags) > > This enables local IRQs, so > > printk_exit_irqrestore() Yes, I like that. John Ogness
