On Mon, Dec 07, 2020 at 04:50:15PM +0100, Peter Zijlstra wrote: > On Wed, Nov 18, 2020 at 12:31:13PM +0800, Aubrey Li wrote: > > Add idle cpumask to track idle cpus in sched domain. When a CPU > > enters idle, if the idle driver indicates to stop tick, this CPU > > is set in the idle cpumask to be a wakeup target. And if the CPU > > is not in idle, the CPU is cleared in idle cpumask during scheduler > > tick to ratelimit idle cpumask update. > > So this will only have SIS consider CPUs that have the tick stopped? > That might affect the facebook tail-latency workloads quite a bit. >
This is the concern I had as well. That's why patch "sched/fair: Avoid revisiting CPUs multiple times during select_idle_sibling" was created. The intent was that a mask could be used as a hint about what runqueues to look at first but continue looking at other runqueues without examining the same runqueue twice. While the patch would not be merged on its own, it may still be relevant in the context of an idle CPU mask depending on how up to date it is. -- Mel Gorman SUSE Labs
