Hi Namhyung and Jiri, > -----Original Message----- > From: Jiri Olsa <[email protected]> > Sent: Monday, December 7, 2020 10:29 PM > To: Namhyung Kim <[email protected]> > Cc: Chanho Park <[email protected]>; Will Deacon <[email protected]>; > Chanho Park <[email protected]>; [email protected]; > [email protected]; [email protected]; linux-arm- > [email protected]; linux-kernel <[email protected]>; > Mike Leach <[email protected]>; Leo Yan <[email protected]>; John > Garry <[email protected]>; Peter Zijlstra <[email protected]>; Ingo > Molnar <[email protected]>; Arnaldo Carvalho de Melo <[email protected]>; > Mark Rutland <[email protected]>; Khem Raj <[email protected]> > Subject: Re: [PATCH] perf arm pmu: fix build error on MUSL libc > > On Mon, Dec 07, 2020 at 09:31:06PM +0900, Namhyung Kim wrote: > > Hi Chanho, > > > > On Mon, Dec 7, 2020 at 8:58 PM Chanho Park <[email protected]> > wrote: > > > > > > Hi Will, > > > > > > > Looks like other files just include this unconditionally, but have > > > > a comment explaining why. See util/branch.h and util/event.h. > > > > Maybe we should do the same for util/pmu.h, which is already > included here? > > > > > > I found below files which perf includes <linux/perf_event.h>. > > > Instead of doing same for all, we'd better put this only for > > > tools/include/uapi/linux/perf_event.h. > > > > It's a copy of the kernel header, I'm not sure we want to add something > there. > > right, we want to copy that directly from kernel uapi so let's not do any > changes in here >
I tried to modify it from include/uapi/linux/perf_event.h but it didn't work. And then, I found perf tool tried to refer the header from tools/include/ directory. I should go include/uapi first and sync the change to tools/ directory. I'll re-spin this patch. Best Regard, Chanho Park
