On Tue, 08 Dec 2020 17:15:07 +0100, Maxime Chevallier wrote:
> Add a documentation for the Rockchip Camera Interface controller
> binding.
>
> This controller can be found on platforms such as the PX30 or the
> RK3288, the PX30 being the only platform supported so far.
>
> Signed-off-by: Maxime Chevallier <[email protected]>
> ---
> v3: Renmed the controller to "vip"
>
> v4: fixed the binding to get a compiling example
>
> .../bindings/media/rockchip-vip.yaml | 94 +++++++++++++++++++
> 1 file changed, 94 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/media/rockchip-vip.yaml
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
./Documentation/devicetree/bindings/media/rockchip-vip.yaml:59:9: [warning]
wrong indentation: expected 6 but found 8 (indentation)
dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/media/rockchip-vip.yaml:
properties:port:properties:required: ['remote-endpoint'] is not of type
'object', 'boolean'
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/media/rockchip-vip.yaml:
properties:port:properties: {'enum': ['$ref', 'additionalItems',
'additionalProperties', 'allOf', 'anyOf', 'const', 'contains', 'default',
'dependencies', 'deprecated', 'description', 'else', 'enum', 'if', 'items',
'maxItems', 'maximum', 'minItems', 'minimum', 'multipleOf', 'not', 'oneOf',
'pattern', 'patternProperties', 'properties', 'propertyNames', 'required',
'then', 'unevaluatedProperties']} is not allowed for 'required'
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/media/rockchip-vip.yaml:
ignoring, error in schema: properties: port: properties: required
warning: no schema found in file:
./Documentation/devicetree/bindings/media/rockchip-vip.yaml
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/media/rockchip-vip.example.dt.yaml:
example-0: vip@ff490000:reg:0: [0, 4282974208, 0, 512] is too long
From schema:
/usr/local/lib/python3.8/dist-packages/dtschema/schemas/reg.yaml
See https://patchwork.ozlabs.org/patch/1412765
The base for the patch is generally the last rc1. Any dependencies
should be noted.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit.
