On 09/12/2020 08:33, Christoph Hellwig wrote: > On Thu, Dec 03, 2020 at 11:48:56AM +0000, Pavel Begunkov wrote: >> It's inlined and the on-stack iter is completely optimised out. Frankly, >> I'd rather not open-code bvec_iter_advance(), at least for this chunk to >> be findable from bvec.h, e.g. grep bvec_iter and bvec_for_each. Though, >> I don't like myself that preamble/postamble. > > Ok. I still think we at least want a separate helper instead of > bloating the main iov_iter_advance.
I agree on that, just haven't got back to it yet. -- Pavel Begunkov
