It was <2020-12-17 czw 11:08>, when Jakub Kicinski wrote: > On Thu, 17 Dec 2020 12:53:30 +0100 Łukasz Stelmach wrote: >> ASIX AX88796[1] is a versatile ethernet adapter chip, that can be >> connected to a CPU with a 8/16-bit bus or with an SPI. This driver >> supports SPI connection. >> >> The driver has been ported from the vendor kernel for ARTIK5[2] >> boards. Several changes were made to adapt it to the current kernel >> which include: >> >> + updated DT configuration, >> + clock configuration moved to DT, >> + new timer, ethtool and gpio APIs, >> + dev_* instead of pr_* and custom printk() wrappers, >> + removed awkward vendor power managemtn. >> + introduced ethtool tunable to control SPI compression >>
[...] >> >> The other ax88796 driver is for NE2000 compatible AX88796L chip. These >> chips are not compatible. Hence, two separate drivers are required. >> >> Signed-off-by: Łukasz Stelmach <l.stelm...@samsung.com> >> Reviewed-by: Andrew Lunn <and...@lunn.ch> > > drivers/net/ethernet/asix/ax88796c_main.c: In function ‘ax88796c_tx_fixup’: > drivers/net/ethernet/asix/ax88796c_main.c:248:6: warning: variable ‘tol_len’ > set but not used [-Wunused-but-set-variable] > 248 | u16 tol_len, pkt_len; > | ^~~~~~~ Done. Thanks. -- Łukasz Stelmach Samsung R&D Institute Poland Samsung Electronics
signature.asc
Description: PGP signature
