From: Palmer Dabbelt
> Sent: 22 December 2020 05:33
>
> From: Palmer Dabbelt <[email protected]>
>
> This cast loses the __iomem qualifier from clint_timer_val, which
> triggers an sparse warning.
>
> Reported-by: kernel test robot <[email protected]>
> Signed-off-by: Palmer Dabbelt <[email protected]>
> ---
> drivers/clocksource/timer-clint.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clocksource/timer-clint.c
> b/drivers/clocksource/timer-clint.c
> index 6cfe2ab73eb0..83a8b38d46f6 100644
> --- a/drivers/clocksource/timer-clint.c
> +++ b/drivers/clocksource/timer-clint.c
> @@ -63,7 +63,7 @@ static struct riscv_ipi_ops clint_ipi_ops = {
> #define clint_get_cycles() readq_relaxed(clint_timer_val)
> #else
> #define clint_get_cycles() readl_relaxed(clint_timer_val)
> -#define clint_get_cycles_hi() readl_relaxed(((u32 *)clint_timer_val)
> + 1)
> +#define clint_get_cycles_hi() readl_relaxed(((u32 __iomem
> *)clint_timer_val) + 1)
> #endif
The correct fix is (probably) to define clint_timer_val as u32 on 32bit systems.
Oh - and get rid of those #defines, they are only used in the
functions just below them.
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT,
UK
Registration No: 1397386 (Wales)
