> -----Original Message----- > From: [email protected] <[email protected]> > Sent: Monday, December 21, 2020 9:54 PM > To: Nilesh Javali <[email protected]>; Manish Rangankar > <[email protected]>; [email protected]; > [email protected] > Cc: GR-QLogic-Storage-Upstream <GR-QLogic-Storage- > [email protected]>; [email protected]; linux- > [email protected]; Tom Rix <[email protected]> > Subject: [PATCH] scsi: qedi: add printf attribute to log function > > From: Tom Rix <[email protected]> > > Attributing the function allows the compiler to more thoroughly check the > use of the function with -Wformat and similar flags. > > Signed-off-by: Tom Rix <[email protected]> > --- > drivers/scsi/qedi/qedi_dbg.h | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/scsi/qedi/qedi_dbg.h b/drivers/scsi/qedi/qedi_dbg.h > index 37d084086fd4..b2c9b0a2db6a 100644 > --- a/drivers/scsi/qedi/qedi_dbg.h > +++ b/drivers/scsi/qedi/qedi_dbg.h > @@ -78,13 +78,16 @@ struct qedi_dbg_ctx { > #define QEDI_INFO(pdev, level, fmt, ...) \ > qedi_dbg_info(pdev, __func__, __LINE__, level, fmt, \ > ## __VA_ARGS__) > - > +__printf(4, 5) > void qedi_dbg_err(struct qedi_dbg_ctx *qedi, const char *func, u32 line, > const char *fmt, ...); > +__printf(4, 5) > void qedi_dbg_warn(struct qedi_dbg_ctx *qedi, const char *func, u32 line, > const char *fmt, ...); > +__printf(4, 5) > void qedi_dbg_notice(struct qedi_dbg_ctx *qedi, const char *func, u32 > line, > const char *fmt, ...); > +__printf(5, 6) > void qedi_dbg_info(struct qedi_dbg_ctx *qedi, const char *func, u32 line, > u32 info, const char *fmt, ...); >
Thanks, Acked-by: Manish Rangankar <[email protected]>
