On Wed, Dec 19, 2007 at 05:18:06PM -0500, [EMAIL PROTECTED] wrote: > commit ab28e1157e970f711c8451b66b3f940ec092db9d > Author: Tony Camuso <[EMAIL PROTECTED]> > Date: Wed Dec 19 15:51:48 2007 -0500 > > Introduces the x86 arch-specific routine that will determine whether > a device responds correctly to MMCONFIG accesses. This routine is > given the generic name pcibios_fix_bus_scan_quirk() > > The comment at the top of the routine explains its logic. > > Signed-off-by: Tony Camuso [EMAIL PROTECTED] > > diff --git a/arch/x86/pci/common.c b/arch/x86/pci/common.c > index 8627463..9b1742d 100644 > --- a/arch/x86/pci/common.c > +++ b/arch/x86/pci/common.c > @@ -525,3 +525,64 @@ struct pci_bus *pci_scan_bus_with_sysdata(int busno) > > return bus; > } > + > +/** > + * This routine traps devices not correctly responding to MMCONFIG access. > + * For each device on the current bus, compare a mmconf read of the > + * vendor/device dword with a legacy PCI config read. If they're not the > same, > + * the bus serving this device must use legacy PCI config accesses instead of > + * mmconf, as must all buses descending from this bus. > + */
Don't user kerneldoc comments for functions that are not really in kerneldoc format. Just a simple /* at the start will be fine, otherwise the tools get confused. So what happens today with these "broken" devices? Does simply reading the vendor id not work properly? What specific hardware does not work today that this is trying to fix? I think this patch set needs a bit of reworking at the very least... thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
