Hi,
On 12/15/20 12:33 AM, Randy Dunlap wrote:
> Fix build warnings when CONFIG_PM_SLEEP is not enabled and these
> functions are not used:
>
> ../drivers/platform/surface/surface_gpe.c:189:12: warning:
> ‘surface_gpe_resume’ defined but not used [-Wunused-function]
> static int surface_gpe_resume(struct device *dev)
> ^~~~~~~~~~~~~~~~~~
> ../drivers/platform/surface/surface_gpe.c:184:12: warning:
> ‘surface_gpe_suspend’ defined but not used [-Wunused-function]
> static int surface_gpe_suspend(struct device *dev)
> ^~~~~~~~~~~~~~~~~~~
>
> Fixes: 274335f1c557 ("platform/surface: Add Driver to set up lid GPEs on MS
> Surface device")
> Signed-off-by: Randy Dunlap <[email protected]>
> Cc: Maximilian Luz <[email protected]>
> Cc: Hans de Goede <[email protected]>
> Cc: [email protected]
> ---
> v2: dropped Maximilian's RVB tag since the patch changed
> use preferred __maybe_unused instead of ifdeffery:
> https://lore.kernel.org/patchwork/patch/732981/
Thank you for your patch, I've applied this patch to my review-hans
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans
Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.
Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.
Regards,
Hans
>
> drivers/platform/surface/surface_gpe.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> --- linux-next-20201214.orig/drivers/platform/surface/surface_gpe.c
> +++ linux-next-20201214/drivers/platform/surface/surface_gpe.c
> @@ -181,12 +181,12 @@ static int surface_lid_enable_wakeup(str
> return 0;
> }
>
> -static int surface_gpe_suspend(struct device *dev)
> +static int __maybe_unused surface_gpe_suspend(struct device *dev)
> {
> return surface_lid_enable_wakeup(dev, true);
> }
>
> -static int surface_gpe_resume(struct device *dev)
> +static int __maybe_unused surface_gpe_resume(struct device *dev)
> {
> return surface_lid_enable_wakeup(dev, false);
> }
>
