> -----Original Message----- > From: Andy Shevchenko <[email protected]> > Sent: Monday, January 4, 2021 3:51 PM > To: Ardelean, Alexandru <[email protected]> > Cc: linux-spi <[email protected]>; Linux Kernel Mailing List <linux- > [email protected]>; Mark Brown <[email protected]>; Stephen Rothwell > <[email protected]> > Subject: Re: [PATCH] spi: stm32: update dev_dbg() print format for SPI params > > [External] > > On Mon, Jan 4, 2021 at 10:55 AM Alexandru Ardelean > <[email protected]> wrote: > > > > With the introduction of the 'include/uapi/linux/spi/spi.h' header, > > the type of the macros are enforced to 'unsigned long int' via the > > _BITUL() macro. > > > > This causes some -Wformat warnings in the spi-stm32 driver. > > This patch changes the printf() specifiers from '%d' to '%lu' to > > accommodate for this change. > > > > Fixes: f7005142dace ("spi: uapi: unify SPI modes into a single spi.h > > header") > > Reported-by: Stephen Rothwell <[email protected]> > > LKP also reported this before. >
Ack; Will add it > ... > > > - dev_dbg(spi->dev, "cpol=%d cpha=%d lsb_first=%d cs_high=%d\n", > > + dev_dbg(spi->dev, "cpol=%lu cpha=%lu lsb_first=%lu > > + cs_high=%lu\n", > > spi_dev->mode & SPI_CPOL, > > spi_dev->mode & SPI_CPHA, > > spi_dev->mode & SPI_LSB_FIRST, > > Wouldn't the output be a bit awful with all these? > > I think the proper fix is to add !! to each bit mask. Fine by me > > -- > With Best Regards, > Andy Shevchenko
