Switch from file_permission() to vfs_permission() in do_path_lookup():
this avoids calling permission() with a NULL nameidata here.

Signed-off-by: Andreas Gruenbacher <[EMAIL PROTECTED]>
Signed-off-by: John Johansen <[EMAIL PROTECTED]>

---
 fs/namei.c |    9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

--- a/fs/namei.c
+++ b/fs/namei.c
@@ -1150,24 +1150,21 @@ static int fastcall do_path_lookup(int d
                path_get(&fs->pwd);
                read_unlock(&fs->lock);
        } else {
-               struct dentry *dentry;
-
                file = fget_light(dfd, &fput_needed);
                retval = -EBADF;
                if (!file)
                        goto out_fail;
 
-               dentry = file->f_path.dentry;
+               nd->path = file->f_path;
 
                retval = -ENOTDIR;
-               if (!S_ISDIR(dentry->d_inode->i_mode))
+               if (!S_ISDIR(nd->path.dentry->d_inode->i_mode))
                        goto fput_fail;
 
-               retval = file_permission(file, MAY_EXEC);
+               retval = vfs_permission(nd, MAY_EXEC);
                if (retval)
                        goto fput_fail;
 
-               nd->path = file->f_path;
                path_get(&file->f_path);
 
                fput_light(file, fput_needed);

-- 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to