On 03/01/2021 05:12, Herbert Xu wrote: > On Tue, Dec 15, 2020 at 06:28:11PM +0800, Tony W Wang-oc wrote: >> The driver crc32c-intel match CPUs supporting X86_FEATURE_XMM4_2. >> On platforms with Zhaoxin CPUs supporting this X86 feature, when >> crc32c-intel and crc32c-generic are both registered, system will >> use crc32c-intel because its .cra_priority is greater than >> crc32c-generic. >> >> When doing lmbench3 Create and Delete file test on partitions with >> ext4 enabling metadata checksum, found using crc32c-generic driver >> could get about 20% performance gain than using the driver crc32c-intel >> on some Zhaoxin CPUs. >> >> This case expect to use crc32c-generic driver for these Zhaoxin CPUs >> to get performance gain, so remove these Zhaoxin CPUs support from >> crc32c-intel. >> >> Signed-off-by: Tony W Wang-oc <tonywwang...@zhaoxin.com> >> --- >> arch/x86/crypto/crc32c-intel_glue.c | 21 +++++++++++++++++++-- >> 1 file changed, 19 insertions(+), 2 deletions(-) > > This does not seem to address the latest comment from hpa. >
Yes, please ignore this patch. Have send new patch set per Hpa's suggestion. Sincerely Tonyw > Thanks, >
