Andrew Morton <[EMAIL PROTECTED]> writes: > On Wed, 19 Dec 2007 16:41:25 -0800 > Andrew Morton <[EMAIL PROTECTED]> wrote: > >> It would be better to just add a stub implementation of >> ht_enable_msi_mapping() for all the other architectures - avoid fancy cpp >> tricks. > > > And by this I really do mean going into each include/asm-*/pci.h and adding > > > struct pci_dev; (if needed) > ... > > static inline void ht_enable_msi_mapping(struct pci_dev *dev) > { > } > > > no macros, no ifdef tricks, no include tricks. Just straight, clean, fully > typechecked C.
Andrew thanks for the code style review. I goofed about recommending the ARCH_HAVE_XXXX thing. I'm going to concentrate on the content for the moment. I think we are very close to a general solution to a very common problem with MSI interrupts. Eric -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/