On Mon, Jan 18, 2021 at 01:27:32PM +0100, Geert Uytterhoeven wrote: > Hi Stafford, > > On Mon, Jan 18, 2021 at 12:43 PM Stafford Horne <[email protected]> wrote: > > On Thu, Jan 14, 2021 at 02:48:49PM +0100, Geert Uytterhoeven wrote: > > > On Thu, Jan 14, 2021 at 3:03 AM Stafford Horne <[email protected]> wrote: > > > > On Mon, Jan 04, 2021 at 05:49:03PM +0100, Geert Uytterhoeven wrote: > > > > > On Mon, Jan 4, 2021 at 5:45 PM Geert Uytterhoeven > > > > > <[email protected]> wrote: > > > > > > Let the LiteX SoC Controller a register a restart handler, which > > > > > > resets
I think there is a typo here: Let the LiteX SoC Controller a register a restart ... should remove the first 'a' and say Let the LiteX SoC Controller register a restart ... > > > > > > the LiteX SoC by writing 1 to CSR_CTRL_RESET_ADDR. > > > > > > > > > > > > Signed-off-by: Geert Uytterhoeven <[email protected]> > > > > > > --- > > > > > > Tested with linux-on-litex-vexriscv. > > > > > > > > > > > > This patch is based on upstream, i.e. not on top of Gabriel Somlo's > > > > > > "[PATCH v5 0/4] drivers/soc/litex: support 32-bit subregisters, > > > > > > 64-bit > > > > > > CPUs" > > > > > > (https://lore.kernel.org/lkml/[email protected]/) > > > > > > > > > > Bummer, and that's why the RESET_REG_* definitions are no longer > > > > > next to the SCRATCH_REG_* definitions :-( > > > > > > > > If it helps I have accepted Gabriel's patches and put them onto > > > > for-next. > > > > > > > > https://github.com/openrisc/linux/commits/for-next > > > > > > > > I am happy to take and test a patch based on that. Or I can do the > > > > adjustments > > > > to base the patch on that myself. Let me know. > > > > > > Thanks for letting me know! V3 sent. > > > > Hi Geert, > > > > I don't seem to see v3 anywhere. Where did you send it and what is the > > subject? > > https://lore.kernel.org/linux-riscv/[email protected]/ > > So "b4 am [email protected]" should give you > a copy. Thanks I got it, I am not sure why it does not show up in my inbox anywhere, sometimes gmail drops mails. Hence, I am replying here. As per the typo above I can fix during applying or you could send during a v4. One more small nit is that you move soc_ctrl_dev out to a static instance it might help to mention. But it's easy to see why. -Stafford
