On Tue, Jan 19, 2021 at 4:18 AM Randy Dunlap <[email protected]> wrote: > > This is the only driver in the kernel source tree that depends on > IRQ_DOMAIN_HIERARCHY instead of selecting it. Since it is not a > visible Kconfig symbol, depending on it (expecting a user to > set/enable it) doesn't make much sense, so change it to select > instead of "depends on". > > Fixes: 96868dce644d ("gpio/sifive: Add GPIO driver for SiFive SoCs") > Signed-off-by: Randy Dunlap <[email protected]> > Cc: Linus Walleij <[email protected]> > Cc: Bartosz Golaszewski <[email protected]> > Cc: [email protected] > Cc: Thierry Reding <[email protected]> > Cc: Greentime Hu <[email protected]> > Cc: Yash Shah <[email protected]> > --- > drivers/gpio/Kconfig | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > --- linux-next-20210118.orig/drivers/gpio/Kconfig > +++ linux-next-20210118/drivers/gpio/Kconfig > @@ -521,7 +521,8 @@ config GPIO_SAMA5D2_PIOBU > > config GPIO_SIFIVE > bool "SiFive GPIO support" > - depends on OF_GPIO && IRQ_DOMAIN_HIERARCHY > + depends on OF_GPIO > + select IRQ_DOMAIN_HIERARCHY > select GPIO_GENERIC > select GPIOLIB_IRQCHIP > select REGMAP_MMIO
Applied, thanks! Bart
