On 1/20/21 11:35 PM, Jakub Kicinski wrote:
On Wed, 20 Jan 2021 16:03:59 -0600 Alex Elder wrote:
Have gsi_channel_update() return the first transaction in the
updated completed transaction list, or NULL if no new transactions
have been added.
Signed-off-by: Alex Elder <[email protected]>
@@ -1452,7 +1452,7 @@ void gsi_channel_doorbell(struct gsi_channel *channel)
}
/* Consult hardware, move any newly completed transactions to completed list */
-static void gsi_channel_update(struct gsi_channel *channel)
+struct gsi_trans *gsi_channel_update(struct gsi_channel *channel)
Why did it lose the 'static'?
It should not have.
My aarch64 build environment did not flag that, but I now built
for x86 and it does. I guess I should make a habit of checking
with that, though it's a bit time-consuming.
I'll send v2 out shortly. Thank you.
-Alex
drivers/net/ipa/gsi.c:1455:19: warning: no previous prototype for
‘gsi_channel_update’ [-Wmissing-prototypes]
1455 | struct gsi_trans *gsi_channel_update(struct gsi_channel *channel)
| ^~~~~~~~~~~~~~~~~~
