Re: [PATCH] spi: altera: Fix memory leak on error path

[matthew . gerlach]

On Wed, 20 Jan 2021, Pan Bian wrote:

Release master that have been previously allocated if the number of
chipselect is invalid.

Fixes: 8e04187c1bc7 ("spi: altera: add SPI core parameters support via platform 
data.")
Signed-off-by: Pan Bian <bianpan2...@163.com>

Acked-by: Matthew Gerlach <matthew.gerl...@linux.intel.com>

---
drivers/spi/spi-altera.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/spi/spi-altera.c b/drivers/spi/spi-altera.c
index cbc4c28c1541..62ea0c9e321b 100644
--- a/drivers/spi/spi-altera.c
+++ b/drivers/spi/spi-altera.c
@@ -254,7 +254,8 @@ static int altera_spi_probe(struct platform_device *pdev)
                        dev_err(&pdev->dev,
                                "Invalid number of chipselect: %hu\n",
                                pdata->num_chipselect);
-                       return -EINVAL;
+                       err = -EINVAL;
+                       goto exit;
                }

                master->num_chipselect = pdata->num_chipselect;
--
2.17.1