"Russell Leidich" <[EMAIL PROTECTED]> writes:

Not sure you have addressed any of my feedback; don't see many changes.

When you repost stuff can you please add a changelog or if you decide
to not address some review comment say why at least.

Also the patch changelog description is missing anyways?

Biggest issue I raised is still not addressed:

> +     /*
> +      * If any of the northbridges has PCI ID 0x1103, then its thermal
> +      * hardware suffers from an erratum which prevents this code from
> +      * working, so abort.
> +      */
> +     for (nb_num = 0; nb_num < num_k8_northbridges; nb_num++) {
> +             if ((k8_northbridges[nb_num]->device) == 0x1103)
> +                     goto out;
> +     }

AFAIK that's all K8s so the code will never work on them. 

-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to