On Mon, Jan 25, 2021 at 6:34 AM Greg KH <[email protected]> wrote: > > On Mon, Jan 25, 2021 at 01:24:25PM +0000, Will Deacon wrote: > > commit dca5244d2f5b94f1809f0c02a549edf41ccd5493 upstream. > > > > GCC versions >= 4.9 and < 5.1 have been shown to emit memory references > > beyond the stack pointer, resulting in memory corruption if an interrupt > > is taken after the stack pointer has been adjusted but before the > > reference has been executed. This leads to subtle, infrequent data > > corruption such as the EXT4 problems reported by Russell King at the > > link below. > > > > Life is too short for buggy compilers, so raise the minimum GCC version > > required by arm64 to 5.1. > > > > Reported-by: Russell King <[email protected]> > > Suggested-by: Arnd Bergmann <[email protected]> > > Signed-off-by: Will Deacon <[email protected]> > > Tested-by: Nathan Chancellor <[email protected]> > > Reviewed-by: Nick Desaulniers <[email protected]> > > Reviewed-by: Nathan Chancellor <[email protected]> > > Acked-by: Linus Torvalds <[email protected]> > > Cc: <[email protected]> # 4.4.y, 4.9.y and 4.14.y only > > Cc: Theodore Ts'o <[email protected]> > > Cc: Florian Weimer <[email protected]> > > Cc: Peter Zijlstra <[email protected]> > > Cc: Nick Desaulniers <[email protected]> > > Cc: Nathan Chancellor <[email protected]> > > Cc: Naresh Kamboju <[email protected]> > > Link: https://lore.kernel.org/r/[email protected] > > Link: https://lore.kernel.org/r/[email protected] > > Signed-off-by: Catalin Marinas <[email protected]> > > [will: backport to 4.4.y/4.9.y/4.14.y; add __clang__ check]
LGTM > > Link: > > https://lore.kernel.org/r/CA+G9fYuzE9WMSB7uGjV4gTzK510SHEdJb_UXQCzsQ5MqA=h...@mail.gmail.com > > Signed-off-by: Will Deacon <[email protected]> > > --- > > include/linux/compiler-gcc.h | 6 ++++++ > > 1 file changed, 6 insertions(+) > > Thanks, now queued up, let's try this again :) > > greg k-h -- Thanks, ~Nick Desaulniers
