From: BingJing Chang <bingji...@synology.com>

If uid or gid of mount options is larger than INT_MAX, isofs_fill_super
will return -EINVAL.

The problem can be encountered by a domain user or reproduced via:
mount -o loop,uid=2147483648 ubuntu-16.04.6-server-amd64.iso /mnt

This can be fixed as commit 233a01fa9c4c ("fuse: handle large user and
group ID").

Reviewed-by: Robbie Ko <robbi...@synology.com>
Reviewed-by: Chung-Chiang Cheng <ccch...@synology.com>
Reviewed-by: Matthew Wilcox <wi...@infradead.org>
Signed-off-by: BingJing Chang <bingji...@synology.com>
---
 fs/isofs/inode.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/fs/isofs/inode.c b/fs/isofs/inode.c
index ec90773..21edc42 100644
--- a/fs/isofs/inode.c
+++ b/fs/isofs/inode.c
@@ -339,6 +339,7 @@ static int parse_options(char *options, struct 
iso9660_options *popt)
 {
        char *p;
        int option;
+       unsigned int uv;
 
        popt->map = 'n';
        popt->rock = 1;
@@ -434,17 +435,17 @@ static int parse_options(char *options, struct 
iso9660_options *popt)
                case Opt_ignore:
                        break;
                case Opt_uid:
-                       if (match_int(&args[0], &option))
+                       if (match_uint(&args[0], &uv))
                                return 0;
-                       popt->uid = make_kuid(current_user_ns(), option);
+                       popt->uid = make_kuid(current_user_ns(), uv);
                        if (!uid_valid(popt->uid))
                                return 0;
                        popt->uid_set = 1;
                        break;
                case Opt_gid:
-                       if (match_int(&args[0], &option))
+                       if (match_uint(&args[0], &uv))
                                return 0;
-                       popt->gid = make_kgid(current_user_ns(), option);
+                       popt->gid = make_kgid(current_user_ns(), uv);
                        if (!gid_valid(popt->gid))
                                return 0;
                        popt->gid_set = 1;
-- 
2.7.4

Reply via email to