> On Fri, 2021-01-29 at 18:20 -0800, mgr...@linux.intel.com wrote:
> > From: "C, Udhayakumar" <udhayakuma...@intel.com>
> >
> > Add Intel tsens IA host driver for Intel Edge.AI Computer Vision
> > platforms.
> []
> > diff --git a/drivers/misc/intel_tsens/intel_tsens_host.c
> > b/drivers/misc/intel_tsens/intel_tsens_host.c
> []
> > +static int tsens_i2c_smbus_read_byte_data(struct i2c_client *i2c, u8
> command,
> > + u8 *i2c_val)
> > +{
> > + union i2c_smbus_data data;
> > + int status;
> > +
> > + status = i2c_smbus_xfer(i2c->adapter, i2c->addr, i2c->flags,
> > + I2C_SMBUS_READ, command,
> > + I2C_SMBUS_BYTE_DATA, &data);
>
> this can fail
>
> > + *i2c_val = data.byte;
>
> Is it appropriate to set the value if it failed and data was not initialized?
>
Thanks for the feedback, I will update as below in next patch version.
if (!status)
*i2c_val = data.byte;
> > + return status;
> > +}
> > +
> > +/**
> > + * intel_tsens_get_temp - get updated temperatue
>
> Might want to use codespell on all files.
Yes we have ran codespell before submitting, looks like codespell dictionary
doesn't have replacement for ' temperatue'.
It has only below words.
temerature->temperature
tempertaure->temperature
temperture->temperature
--
udhay
>
