On Wed, 02 Jan 2008 09:51:38 -0800
Roland Dreier <[EMAIL PROTECTED]> wrote:
> > > Can you try this?
> >
> > That patched oopsed in scsi_remove_host(), but reversing the order has
> > survived over 500 insert/probe/remove cycles.
> >
> > Tested-by: David Dillow <[EMAIL PROTECTED]>
> > ---
> > diff --git a/drivers/infiniband/ulp/srp/ib_srp.c
> b/drivers/infiniband/ulp/srp/ib_srp.c
> > index 950228f..77e8b90 100644
> > --- a/drivers/infiniband/ulp/srp/ib_srp.c
> > +++ b/drivers/infiniband/ulp/srp/ib_srp.c
> > @@ -2054,6 +2054,7 @@ static void srp_remove_one(struct ib_device *device)
> > list_for_each_entry_safe(target, tmp_target,
> > &host->target_list, list) {
> > scsi_remove_host(target->scsi_host);
> > + srp_remove_host(target->scsi_host);
> > srp_disconnect_target(target);
>
> Where do we stand on this? What is the right place to put the
> srp_remove_host? Is there a bug somewhere else?
{sas|fc}_remove_host is called before scsi_remove_host. And in
srp_remove_work(), we call srp_remove_host and then
scsi_remove_host. ibmvscsi also calls them in that order.
I thought that I messed up something in srp_transport_class. But I
can't figure out what's wrong. The above patch works and is unlikely
to lead to critical problems so I'm fine with it for now.
> I'd like to get this fixed before 2.6.24 final comes out...
Yeah, it should be fixed.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
