Hello, On Wed, Feb 3, 2021 at 10:58 PM Alexander Antonov <alexander.anto...@linux.intel.com> wrote: > > Adding AGGR_PCIE_PORT mode to be able to distinguish aggr_mode > for root ports in following patches.
I'm not sure adding the AGGR_PCIE_PORT is the right way. In my understanding, the aggr mode is to specify how we aggregate counter values of a single event from different cpus. But this seems to aggregate counter values from different events. Also the new mode is basically the same as AGGR_GLOBAL. As you will add stat_config.iostat_run to distinguish the iostat command, probably we just want to use the global aggr mode (and it's the default!) and get rid of the AGGR_PCIE_PORT. Thoughts? Thanks, Namhyung
