On Thu, Feb 04, 2021 at 05:17:07PM +0300, Heikki Krogerus wrote: > The function dwc2_pci_quirks() does nothing. Removing. > > Signed-off-by: Heikki Krogerus <[email protected]> > Cc: Minas Harutyunyan <[email protected]> > --- > drivers/usb/dwc2/pci.c | 18 ------------------ > 1 file changed, 18 deletions(-) > > diff --git a/drivers/usb/dwc2/pci.c b/drivers/usb/dwc2/pci.c > index 7afc10872f1f0..0000151e3ca96 100644 > --- a/drivers/usb/dwc2/pci.c > +++ b/drivers/usb/dwc2/pci.c > @@ -63,20 +63,6 @@ struct dwc2_pci_glue { > struct platform_device *phy; > }; > > -static int dwc2_pci_quirks(struct pci_dev *pdev, struct platform_device > *dwc2) > -{ > - if (pdev->vendor == PCI_VENDOR_ID_SYNOPSYS && > - pdev->device == PCI_PRODUCT_ID_HAPS_HSOTG) { > - struct property_entry properties[] = { > - { }, > - }; > - > - return platform_device_add_properties(dwc2, properties); > - } > - > - return 0; > -} > - > /** > * dwc2_pci_probe() - Provides the cleanup entry points for the DWC_otg PCI > * driver > @@ -143,10 +129,6 @@ static int dwc2_pci_probe(struct pci_dev *pci, > > dwc2->dev.parent = dev; > > - ret = dwc2_pci_quirks(pci, dwc2); > - if (ret) > - goto err; > - > glue = devm_kzalloc(dev, sizeof(*glue), GFP_KERNEL); > if (!glue) { > ret = -ENOMEM;
This is crazy. I'll go apply this right now :) thanks, greg k-h
