On 04/02/2021 at 17:01, Arnd Bergmann wrote:
From: Arnd Bergmann <[email protected]>

Compiling with the clang integrated assembler warns about
a recently added instruction:

<instantiation>:14:13: error: unknown token in expression
  ldr tmp1, =#0x00020010UL
arch/arm/mach-at91/pm_suspend.S:542:2: note: while in macro instantiation
  at91_plla_enable

Remove the extra '#' character that is not used for the 'ldr'
instruction when doing an indirect load of a constant.

Fixes: 4fd36e458392 ("ARM: at91: pm: add plla disable/enable support for 
sam9x60")
Signed-off-by: Arnd Bergmann <[email protected]>

Looks good to me:
Acked-by: Nicolas Ferre <[email protected]>

Thanks!

Best regards,
  Nicolas

---
  arch/arm/mach-at91/pm_suspend.S | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/mach-at91/pm_suspend.S b/arch/arm/mach-at91/pm_suspend.S
index 909856c8a8c6..0d467cc40129 100644
--- a/arch/arm/mach-at91/pm_suspend.S
+++ b/arch/arm/mach-at91/pm_suspend.S
@@ -446,7 +446,7 @@ ENDPROC(at91_backup_mode)
         str     tmp1, [pmc, #AT91_PMC_PLL_UPDT]

         /* step 2. */
-       ldr     tmp1, =#AT91_PMC_PLL_ACR_DEFAULT_PLLA
+       ldr     tmp1, =AT91_PMC_PLL_ACR_DEFAULT_PLLA
         str     tmp1, [pmc, #AT91_PMC_PLL_ACR]

         /* step 3. */
--
2.29.2



--
Nicolas Ferre

Reply via email to