On Thu, Feb 04, 2021 at 10:54:27PM +0100, Rikard Falkeborn wrote: > The only usage of ppi_attr_grp is to put its address in an array of > pointers to const struct attribute_group. Make it const to allow the > compiler to put it in read-only memory. > > Signed-off-by: Rikard Falkeborn <[email protected]>
Thanks. Reviewed-by: Jarkko Sakkinen <[email protected]> /Jarkko > --- > drivers/char/tpm/tpm_ppi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/char/tpm/tpm_ppi.c b/drivers/char/tpm/tpm_ppi.c > index b2dab941cb7f..40018a73b3cb 100644 > --- a/drivers/char/tpm/tpm_ppi.c > +++ b/drivers/char/tpm/tpm_ppi.c > @@ -358,7 +358,7 @@ static struct attribute *ppi_attrs[] = { > &dev_attr_tcg_operations.attr, > &dev_attr_vs_operations.attr, NULL, > }; > -static struct attribute_group ppi_attr_grp = { > +static const struct attribute_group ppi_attr_grp = { > .name = "ppi", > .attrs = ppi_attrs > }; > -- > 2.30.0 > >
