It is redundant to do irqsave and irqrestore in hardIRQ context, where
it has been in a irq-disabled context.

Signed-off-by: Xiaofei Tan <[email protected]>
---
 drivers/scsi/nsp32.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/scsi/nsp32.c b/drivers/scsi/nsp32.c
index e44b1a0..d927fde 100644
--- a/drivers/scsi/nsp32.c
+++ b/drivers/scsi/nsp32.c
@@ -1152,12 +1152,11 @@ static irqreturn_t do_nsp32_isr(int irq, void *dev_id)
        struct scsi_cmnd *SCpnt = data->CurrentSC;
        unsigned short auto_stat, irq_stat, trans_stat;
        unsigned char busmon, busphase;
-       unsigned long flags;
        int ret;
        int handled = 0;
        struct Scsi_Host *host = data->Host;
 
-       spin_lock_irqsave(host->host_lock, flags);
+       spin_lock(host->host_lock);
 
        /*
         * IRQ check, then enable IRQ mask
@@ -1421,7 +1420,7 @@ static irqreturn_t do_nsp32_isr(int irq, void *dev_id)
        nsp32_write2(base, IRQ_CONTROL, 0);
 
  out2:
-       spin_unlock_irqrestore(host->host_lock, flags);
+       spin_unlock(host->host_lock);
 
        nsp32_dbg(NSP32_DEBUG_INTR, "exit");
 
-- 
2.8.1

Reply via email to