On Sun, Feb 7, 2021 at 10:00 AM Yang Li <[email protected]> wrote:
> Eliminate the following coccicheck warning: > ./drivers/gpio/gpiolib-cdev.c:2307:7-23: WARNING: gpio_fileops: .read() > has stream semantic; safe to change nonseekable_open -> stream_open. > > Reported-by: Abaci Robot <[email protected]> > Signed-off-by: Yang Li <[email protected]> This doesn't make any sense to me. It is pretty clear from context that this file should *not* be seeked and it seems just dangerous to randomly allow that. Better safe than sorry. I don't know if the function nonseekable_open() has an unintuitive name if it means anything else than that. I burnt myself on the FS before. Yours, Linus Walleij
